-
Notifications
You must be signed in to change notification settings - Fork 106
Added Transparency Border to recipe-background and catalyst-tab #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please use spotlessApply |
|
I have already done the /gradlew spotlessApply. |
|
This needs to be re-opened or some fix needs to be added. Because of that PR all of the NEI backgrounds are misaligned, there were already some fixes for the GT NEI pages, but not in other (all of them) mods.
and it won't be nice to literally edit some numbers on every mod + have some NEI pages not aligned because of ARR mods. I propose some if statement here (names up to you) Also the above pr should be rolled back ofc (or at least partly to get the default positioning) |
|
@Ranzuu this PR don't connected with this PR. The offset of 2 in some handlers (mainly gt) is due to a change in the alignment of handlers within the window. This was changed in this PR: #792 |
|
I am pretty sure the wrong handler allignmemt of some mods is not caused due to my PR. I only touched the draw function and the background image is in drawn in exact the same place as before. And if the most handlers are working, but some not, its no fault from the background drawing. Or is there some dependency for the draw function of the background? Anyways later I will have a look into it and revert my changes to be sure. |
|
@timb8g We found the reason for the shift of handlers and it is not related to this PR |

Because NEI-GTNH has broken all resource packs for NEI. I have tried to fix the patch from PureBDcraft, but recognized its not easy because we had only 6px (24px in 128x resource packs) to make a border around the recipe background due to the dynamic layout drawing.
So I thought it would be a good idea to add more space to create textures :)
First I tried to increase the Border Padding, but this one had too much dependencies for positioning of other gui elements.
So I focused on extending only the background texture in the draw function. I called it Transparency Border :)
Additionally I had done the same for the catalyst-tab to have a good alignment here.
As result the default texture looks the same as before and I was able to fix the PureBDcraft patch.
This change should help every guy who will create resources for this mod, except the guy from Faithful ^^
Before:

After:
