Skip to content

Conversation

@timb8g
Copy link

@timb8g timb8g commented Dec 17, 2025

Because NEI-GTNH has broken all resource packs for NEI. I have tried to fix the patch from PureBDcraft, but recognized its not easy because we had only 6px (24px in 128x resource packs) to make a border around the recipe background due to the dynamic layout drawing.

So I thought it would be a good idea to add more space to create textures :)

First I tried to increase the Border Padding, but this one had too much dependencies for positioning of other gui elements.
So I focused on extending only the background texture in the draw function. I called it Transparency Border :)

Additionally I had done the same for the catalyst-tab to have a good alignment here.

As result the default texture looks the same as before and I was able to fix the PureBDcraft patch.
This change should help every guy who will create resources for this mod, except the guy from Faithful ^^

Before:
Bildschirmfoto 2025-12-16 um 23 23 52

After:
Bildschirmfoto 2025-12-17 um 00 34 36

@Dream-Master Dream-Master requested a review from slprime December 17, 2025 06:59
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Dec 17, 2025
@slprime
Copy link
Member

slprime commented Dec 17, 2025

Please use spotlessApply

@timb8g
Copy link
Author

timb8g commented Dec 18, 2025

I have already done the /gradlew spotlessApply.
Something else I need to do?

@slprime
Copy link
Member

slprime commented Dec 20, 2025

I have already done the /gradlew spotlessApply. Something else I need to do?

try it again because problem is still here

image

@Dream-Master Dream-Master merged commit 454b4f7 into GTNewHorizons:master Dec 28, 2025
1 check passed
@Dream-Master Dream-Master removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Dec 28, 2025
@slprime slprime mentioned this pull request Jan 13, 2026
@Ranzuu
Copy link

Ranzuu commented Jan 18, 2026

This needs to be re-opened or some fix needs to be added. Because of that PR all of the NEI backgrounds are misaligned, there were already some fixes for the GT NEI pages, but not in other (all of them) mods.

and it won't be nice to literally edit some numbers on every mod + have some NEI pages not aligned because of ARR mods.
@timb8g

I propose some if statement here
if this exist: nei:textures/gui/recipebgCUSTOM.png (with the transparency border - bigger texture) use it
if not present use normal nei:textures/gui/recipebg.png. with normal numbers they were before
That way default is default, and if you wanna add the transparency via the resource pack, it will use the recipebgCUSTOM.png texture.

(names up to you)

Also the above pr should be rolled back ofc (or at least partly to get the default positioning)

@slprime
Copy link
Member

slprime commented Jan 18, 2026

@Ranzuu this PR don't connected with this PR. The offset of 2 in some handlers (mainly gt) is due to a change in the alignment of handlers within the window.

This was changed in this PR: #792
Previously, the alignment looked like this: widget.setLocation(Math.max(0, (this.container.w - widget.w) / 2), shiftY);, and now it uses widget.setLocation(0, shiftY);. The old alignment broke some handlers, but unfortunately, I didn't provide examples in the PR to remember them

@timb8g
Copy link
Author

timb8g commented Jan 19, 2026

I am pretty sure the wrong handler allignmemt of some mods is not caused due to my PR.

I only touched the draw function and the background image is in drawn in exact the same place as before.

And if the most handlers are working, but some not, its no fault from the background drawing.

Or is there some dependency for the draw function of the background?

Anyways later I will have a look into it and revert my changes to be sure.

@slprime
Copy link
Member

slprime commented Jan 19, 2026

@timb8g We found the reason for the shift of handlers and it is not related to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants